test: isolate browser network guards

This commit is contained in:
Peter Steinberger
2026-04-11 00:07:20 +01:00
parent 4ff237d776
commit a18c717add
5 changed files with 154 additions and 3 deletions

View File

@@ -1,5 +1,5 @@
import { createServer } from "node:http";
import { afterEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { type WebSocket, WebSocketServer } from "ws";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import { rawDataToString } from "../infra/ws.js";
@@ -9,6 +9,21 @@ import { parseHttpUrl } from "./config.js";
import { BrowserCdpEndpointBlockedError } from "./errors.js";
import { InvalidBrowserNavigationUrlError } from "./navigation-guard.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
describe("cdp", () => {
let httpServer: ReturnType<typeof createServer> | null = null;
let wsServer: WebSocketServer | null = null;
@@ -57,6 +72,7 @@ describe("cdp", () => {
};
afterEach(async () => {
vi.unstubAllEnvs();
await new Promise<void>((resolve) => {
if (!httpServer) {
return resolve();
@@ -487,3 +503,17 @@ describe("parseHttpUrl with WebSocket protocols", () => {
expect(() => parseHttpUrl("file:///etc/passwd", "test")).toThrow("must be http(s) or ws(s)");
});
});
const proxyEnvKeys = [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
] as const;
beforeEach(() => {
for (const key of proxyEnvKeys) {
vi.stubEnv(key, "");
}
});

View File

@@ -1,6 +1,42 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { BrowserDispatchResponse } from "./routes/dispatcher.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
vi.mock("openclaw/plugin-sdk/ssrf-runtime", async () => {
const actual = await vi.importActual<typeof import("openclaw/plugin-sdk/ssrf-runtime")>(
"openclaw/plugin-sdk/ssrf-runtime",
);
return {
...actual,
fetchWithSsrFGuard: async (params: {
url: string;
init?: RequestInit;
signal?: AbortSignal;
}) => ({
response: await fetch(params.url, {
...params.init,
signal: params.signal,
}),
finalUrl: params.url,
release: async () => {},
}),
};
});
function okDispatchResponse(): BrowserDispatchResponse {
return { status: 200, body: { ok: true } };
}
@@ -87,6 +123,16 @@ async function expectThrownBrowserFetchError(
describe("fetchBrowserJson loopback auth", () => {
beforeEach(() => {
vi.restoreAllMocks();
for (const key of [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
]) {
vi.stubEnv(key, "");
}
vi.stubEnv("OPENCLAW_GATEWAY_TOKEN", "loopback-token");
mocks.loadConfig.mockClear();
mocks.loadConfig.mockReturnValue({

View File

@@ -1,5 +1,5 @@
import { chromium } from "playwright-core";
import { afterEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { SsrFBlockedError } from "../infra/net/ssrf.js";
import * as chromeModule from "./chrome.js";
import { BrowserTabNotFoundError } from "./errors.js";
@@ -15,9 +15,33 @@ import {
listPagesViaPlaywright,
} from "./pw-session.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
const connectOverCdpSpy = vi.spyOn(chromium, "connectOverCDP");
const getChromeWebSocketUrlSpy = vi.spyOn(chromeModule, "getChromeWebSocketUrl");
const PROXY_ENV_KEYS = [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
] as const;
type MockRoute = { continue: () => Promise<void>; abort: () => Promise<void> };
type MockRequest = {
isNavigationRequest: () => boolean;
@@ -170,7 +194,14 @@ function mockBlockedRedirectNavigation(params: {
});
}
beforeEach(() => {
for (const key of PROXY_ENV_KEYS) {
vi.stubEnv(key, "");
}
});
afterEach(async () => {
vi.unstubAllEnvs();
connectOverCdpSpy.mockClear();
getChromeWebSocketUrlSpy.mockClear();
await closePlaywrightBrowserConnection().catch(() => {});

View File

@@ -7,6 +7,21 @@ import {
setPwToolsCoreCurrentPage,
} from "./pw-tools-core.test-harness.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
installPwToolsCoreTestHooks();
const mod = await import("./pw-tools-core.snapshot.js");

View File

@@ -1,7 +1,22 @@
import fs from "node:fs";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { BrowserServerState } from "./server-context.js";
vi.mock("openclaw/plugin-sdk/browser-security-runtime", async () => {
const actual = await vi.importActual<
typeof import("openclaw/plugin-sdk/browser-security-runtime")
>("openclaw/plugin-sdk/browser-security-runtime");
const lookupFn = async (_hostname: string, options?: { all?: boolean }) => {
const result = { address: "93.184.216.34", family: 4 };
return options?.all === true ? [result] : result;
};
return {
...actual,
resolvePinnedHostnameWithPolicy: (hostname: string, params: object = {}) =>
actual.resolvePinnedHostnameWithPolicy(hostname, { ...params, lookupFn: lookupFn as never }),
};
});
vi.mock("./chrome-mcp.js", () => ({
closeChromeMcpSession: vi.fn(async () => true),
ensureChromeMcpAvailable: vi.fn(async () => {}),
@@ -59,9 +74,23 @@ function makeState(): BrowserServerState {
}
beforeEach(() => {
for (const key of [
"ALL_PROXY",
"all_proxy",
"HTTP_PROXY",
"http_proxy",
"HTTPS_PROXY",
"https_proxy",
]) {
vi.stubEnv(key, "");
}
vi.clearAllMocks();
});
afterEach(() => {
vi.unstubAllEnvs();
});
describe("browser server-context existing-session profile", () => {
it("routes tab operations through the Chrome MCP backend", async () => {
fs.mkdirSync("/tmp/brave-profile", { recursive: true });