vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 09:20:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(doctor): skip token generation for trusted-proxy and none auth modes (#59055)

Browse Source 
runGatewayAuthHealth() only excluded 'password' and 'token' (with existing
token) from its needsToken check. When gateway.auth.mode was set to
'trusted-proxy' or 'none', doctor --fix would incorrectly:

1. Flag the config as 'missing a token'
2. Prompt to generate a gateway token
3. Overwrite auth.mode to 'token' in openclaw.json

This silently broke trusted-proxy deployments (common in SaaS/reverse-proxy
setups) by replacing the delegated auth mode with token auth.

The fix aligns runGatewayAuthHealth() with the existing
hasExplicitGatewayInstallAuthMode() in auth-install-policy.ts, which
already correctly returns false for 'password', 'none', and 'trusted-proxy'.

Co-authored-by: wujiaming88 <wujiaming88@example.com>
This commit is contained in:
Garming
2026-04-22 22:38:27 +08:00
committed by GitHub
parent 38135ff6b4
commit a43be09dca
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/flows/doctor-health-contributions.ts
View File

@@ -123,7 +123,15 @@ async function runGatewayAuthHealth(ctx: DoctorHealthFlowContext): Promise<void>
authConfig: ctx.cfg.gateway?.auth,
tailscaleMode: ctx.cfg.gateway?.tailscale?.mode ?? "off",
});
const needsToken = auth.mode !== "password" && (auth.mode !== "token" || !auth.token);
// Modes that don't need a token: password, none, trusted-proxy.
// This aligns with hasExplicitGatewayInstallAuthMode() in auth-install-policy.ts.
// Previously, only "password" and "token" (with a token present) were excluded,
// causing doctor --fix to overwrite trusted-proxy/none configs with token mode.
const needsToken =
auth.mode !== "password" &&
auth.mode !== "none" &&
auth.mode !== "trusted-proxy" &&
(auth.mode !== "token" || !auth.token);
if (!needsToken) {
return;
}