vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 13:30:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: cover deleted-agent guard on sessionId and label resolve paths

Browse Source
This commit is contained in:
bittoby
2026-04-16 07:07:26 +02:00
committed by Gustavo Madeira Santana
parent 0d473e8020
commit ae17248040
1 changed files with 53 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
src/gateway/sessions-resolve.test.ts
View File

@@ -8,6 +8,7 @@ const hoisted = vi.hoisted(() => ({
listSessionsFromStoreMock: vi.fn(),
migrateAndPruneGatewaySessionStoreKeyMock: vi.fn(),
resolveGatewaySessionStoreTargetMock: vi.fn(),
loadCombinedSessionStoreForGatewayMock: vi.fn(),
listAgentIdsMock: vi.fn(),
}));
@@ -38,6 +39,7 @@ vi.mock("./session-utils.js", async () => {
listSessionsFromStore: hoisted.listSessionsFromStoreMock,
migrateAndPruneGatewaySessionStoreKey: hoisted.migrateAndPruneGatewaySessionStoreKeyMock,
resolveGatewaySessionStoreTarget: hoisted.resolveGatewaySessionStoreTargetMock,
loadCombinedSessionStoreForGateway: hoisted.loadCombinedSessionStoreForGatewayMock,
};
});
@@ -54,6 +56,7 @@ describe("resolveSessionKeyFromResolveParams", () => {
hoisted.listSessionsFromStoreMock.mockReset();
hoisted.migrateAndPruneGatewaySessionStoreKeyMock.mockReset();
hoisted.resolveGatewaySessionStoreTargetMock.mockReset();
hoisted.loadCombinedSessionStoreForGatewayMock.mockReset();
hoisted.listAgentIdsMock.mockReset();
// Default: all agents are known (main is always present).
hoisted.listAgentIdsMock.mockReturnValue(["main"]);
@@ -154,4 +157,54 @@ describe("resolveSessionKeyFromResolveParams", () => {
},
});
});
it("rejects sessions belonging to a deleted agent (sessionId-based lookup)", async () => {
const deletedAgentKey = "agent:deleted-agent:main";
hoisted.loadCombinedSessionStoreForGatewayMock.mockReturnValue({
storePath,
store: { [deletedAgentKey]: { sessionId: "sess-orphan", updatedAt: 1 } },
});
hoisted.listSessionsFromStoreMock.mockReturnValue({
sessions: [{ key: deletedAgentKey, sessionId: "sess-orphan" }],
});
hoisted.listAgentIdsMock.mockReturnValue(["main"]);
const result = await resolveSessionKeyFromResolveParams({
cfg: {},
p: { sessionId: "sess-orphan" },
});
expect(result).toEqual({
ok: false,
error: {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
},
});
});
it("rejects sessions belonging to a deleted agent (label-based lookup)", async () => {
const deletedAgentKey = "agent:deleted-agent:main";
hoisted.loadCombinedSessionStoreForGatewayMock.mockReturnValue({
storePath,
store: { [deletedAgentKey]: { sessionId: "sess-orphan", updatedAt: 1, label: "my-label" } },
});
hoisted.listSessionsFromStoreMock.mockReturnValue({
sessions: [{ key: deletedAgentKey, sessionId: "sess-orphan", label: "my-label" }],
});
hoisted.listAgentIdsMock.mockReturnValue(["main"]);
const result = await resolveSessionKeyFromResolveParams({
cfg: {},
p: { label: "my-label" },
});
expect(result).toEqual({
ok: false,
error: {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
},
});
});
});