vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-18 17:14:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: tighten msteams bot framework assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-11 03:07:44 +01:00
parent ee94008ad1
commit b62fded4c2
1 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
extensions/msteams/src/attachments/bot-framework.test.ts
View File

@@ -142,7 +142,8 @@ describe("downloadMSTeamsBotFrameworkAttachment", () => {
fetchFn,
});
expect(media).toMatchObject({ path: runtime.savePath });
expect(media?.path).toBe(runtime.savePath);
expect(media?.contentType).toBe(runtime.savedContentType);
expect(runtime.saveCalls).toHaveLength(1);
expect(runtime.saveCalls[0].buffer.toString("utf-8")).toBe("PDFBYTES");
});
@@ -267,7 +268,8 @@ describe("downloadMSTeamsBotFrameworkAttachment", () => {
fetchFn,
});
expect(media).toMatchObject({ path: runtime.savePath });
expect(media?.path).toBe(runtime.savePath);
expect(media?.contentType).toBe(runtime.savedContentType);
// Both the attachment info call and the view call should be observed,
// confirming the direct fetch path was taken (no dispatcher interception).
expect(fetchCalls).toHaveLength(2);
@@ -298,12 +300,11 @@ describe("downloadMSTeamsBotFrameworkAttachment", () => {
});
expect(media).toBeUndefined();
expect(warn).toHaveBeenCalledWith(
expect(warn).toHaveBeenCalledTimes(1);
expect(warn.mock.calls[0]).toStrictEqual([
"msteams botFramework attachmentInfo fetch failed",
expect.objectContaining({
error: expect.stringContaining("invalid onRequestStart method"),
}),
);
{ error: "fetch failed | invalid onRequestStart method" },
]);
});
it("logs a warning when the attachmentView fetch throws", async () => {
@@ -335,12 +336,11 @@ describe("downloadMSTeamsBotFrameworkAttachment", () => {
});
expect(media).toBeUndefined();
expect(warn).toHaveBeenCalledWith(
expect(warn).toHaveBeenCalledTimes(1);
expect(warn.mock.calls[0]).toStrictEqual([
"msteams botFramework attachmentView fetch failed",
expect.objectContaining({
error: expect.stringContaining("fetch failed"),
}),
);
{ error: "fetch failed" },
]);
});
it("logs a warning on non-ok attachmentInfo response", async () => {
@@ -362,10 +362,11 @@ describe("downloadMSTeamsBotFrameworkAttachment", () => {
});
expect(media).toBeUndefined();
expect(warn).toHaveBeenCalledWith(
expect(warn).toHaveBeenCalledTimes(1);
expect(warn.mock.calls[0]).toStrictEqual([
"msteams botFramework attachmentInfo non-ok",
expect.objectContaining({ status: 500 }),
);
{ status: 500 },
]);
});
});
});