vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 07:20:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: keep typing for group message-tool replies

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-28 08:27:06 +01:00
parent 2f3e81fec2
commit bb7e8624ab
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/auto-reply/reply/dispatch-from-config.test.ts
View File

@@ -3891,7 +3891,10 @@ describe("sendPolicy deny — suppress delivery, not processing (#53328)", () =>
sendPolicy: "deny",
};
const dispatcher = createDispatcher();
const replyResolver = vi.fn(async () => ({ text: "agent reply" }) satisfies ReplyPayload);
const replyResolver = vi.fn(async (_ctx: MsgContext, opts?: GetReplyOptions) => {
expect(opts?.suppressTyping).toBe(true);
return { text: "agent reply" } satisfies ReplyPayload;
});
const ctx = buildTestCtx({ SessionKey: "test:session" });
await dispatchReplyFromConfig({
@@ -4220,8 +4223,11 @@ describe("sendPolicy deny — suppress delivery, not processing (#53328)", () =>
itemEvent: vi.fn(),
planUpdate: vi.fn(),
toolResult: vi.fn(),
typingStart: vi.fn(async () => {}),
};
const replyResolver = vi.fn(async (_ctx: MsgContext, opts?: GetReplyOptions) => {
expect(opts?.suppressTyping).toBe(false);
await opts?.onReplyStart?.();
await opts?.onPartialReply?.({ text: "draft leak" });
await opts?.onReasoningStream?.({ text: "reasoning leak" });
await opts?.onAssistantMessageStart?.();
@@ -4244,6 +4250,7 @@ describe("sendPolicy deny — suppress delivery, not processing (#53328)", () =>
onPartialReply: callbacks.partial,
onReasoningStream: callbacks.reasoning,
onAssistantMessageStart: callbacks.assistantStart,
onReplyStart: callbacks.typingStart,
onBlockReplyQueued: callbacks.blockQueued,
onToolStart: callbacks.toolStart,
onItemEvent: callbacks.itemEvent,
@@ -4257,7 +4264,11 @@ describe("sendPolicy deny — suppress delivery, not processing (#53328)", () =>
expect(dispatcher.sendFinalReply).not.toHaveBeenCalled();
expect(dispatcher.sendBlockReply).not.toHaveBeenCalled();
expect(dispatcher.sendToolResult).not.toHaveBeenCalled();
for (const callback of Object.values(callbacks)) {
expect(callbacks.typingStart).toHaveBeenCalledTimes(1);
for (const [name, callback] of Object.entries(callbacks)) {
if (name === "typingStart") {
continue;
}
expect(callback).not.toHaveBeenCalled();
}
expect(hookMocks.runner.runReplyDispatch).toHaveBeenCalledWith(
@@ -4275,6 +4286,7 @@ describe("sendPolicy deny — suppress delivery, not processing (#53328)", () =>
const dispatcher = createDispatcher();
const replyResolver = vi.fn(async (_ctx: MsgContext, opts?: GetReplyOptions) => {
expect(opts?.sourceReplyDeliveryMode).toBe("message_tool_only");
expect(opts?.suppressTyping).toBe(false);
return { text: "final reply" } satisfies ReplyPayload;
});

2
src/auto-reply/reply/dispatch-from-config.ts
View File

@@ -1054,7 +1054,7 @@ export async function dispatchReplyFromConfig(
const typing = resolveRunTypingPolicy({
requestedPolicy: params.replyOptions?.typingPolicy,
suppressTyping:
suppressDelivery || params.replyOptions?.suppressTyping === true || shouldSuppressTyping,
sendPolicyDenied || params.replyOptions?.suppressTyping === true || shouldSuppressTyping,
originatingChannel: routeReplyChannel,
systemEvent: shouldRouteToOriginating,
});