mirror of
https://github.com/openclaw/openclaw.git
synced 2026-03-12 07:20:45 +00:00
fix: distinguish warning message for non-OpenClaw vs missing npm package
Address Greptile review: show "not a valid OpenClaw plugin" when the npm package was found but lacks openclaw.extensions, instead of the misleading "npm package unavailable" message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
committed by
Peter Steinberger
parent
da8a17d8de
commit
bfb6c6290f
@@ -638,11 +638,10 @@ export function registerPluginsCli(program: Command) {
|
||||
logger: createPluginInstallLogger(),
|
||||
});
|
||||
if (!result.ok) {
|
||||
const shouldTryBundledFallback =
|
||||
isPackageNotFoundInstallError(result.error) || isNotAnOpenClawPluginError(result.error);
|
||||
const bundledFallback = shouldTryBundledFallback
|
||||
? findBundledPluginByNpmSpec({ spec: raw })
|
||||
: undefined;
|
||||
const isNpmNotFound = isPackageNotFoundInstallError(result.error);
|
||||
const isNotPlugin = isNotAnOpenClawPluginError(result.error);
|
||||
const bundledFallback =
|
||||
isNpmNotFound || isNotPlugin ? findBundledPluginByNpmSpec({ spec: raw }) : undefined;
|
||||
if (!bundledFallback) {
|
||||
defaultRuntime.error(result.error);
|
||||
process.exit(1);
|
||||
@@ -680,7 +679,9 @@ export function registerPluginsCli(program: Command) {
|
||||
logSlotWarnings(slotResult.warnings);
|
||||
defaultRuntime.log(
|
||||
theme.warn(
|
||||
`npm package unavailable for ${raw}; using bundled plugin at ${shortenHomePath(bundledFallback.localPath)}.`,
|
||||
isNpmNotFound
|
||||
? `npm package unavailable for ${raw}; using bundled plugin at ${shortenHomePath(bundledFallback.localPath)}.`
|
||||
: `npm package "${raw}" is not a valid OpenClaw plugin; using bundled plugin at ${shortenHomePath(bundledFallback.localPath)}.`,
|
||||
),
|
||||
);
|
||||
defaultRuntime.log(`Installed plugin: ${bundledFallback.pluginId}`);
|
||||
|
||||
Reference in New Issue
Block a user