vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 07:50:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(telegram): dedupe exec approval resolver cases

Browse Source
This commit is contained in:
Vincent Koc
2026-04-12 05:27:02 +01:00
parent 22b53a4973
commit c3c13ea381
1 changed files with 42 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
extensions/telegram/src/exec-approval-resolver.test.ts
View File

@@ -10,6 +10,38 @@ vi.mock("openclaw/plugin-sdk/approval-gateway-runtime", () => ({
}));
describe("resolveTelegramExecApproval", () => {
async function invokeResolver(params: {
approvalId: string;
decision: string;
senderId: string;
allowPluginFallback?: boolean;
}) {
const { resolveTelegramExecApproval } = await import("./exec-approval-resolver.js");
await resolveTelegramExecApproval({
cfg: {} as never,
gatewayUrl: undefined,
...params,
});
}
function expectApprovalGatewayCall(params: {
approvalId: string;
decision: string;
senderId: string;
allowPluginFallback?: boolean;
}) {
expect(approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy).toHaveBeenCalledWith({
cfg: {} as never,
approvalId: params.approvalId,
decision: params.decision,
senderId: params.senderId,
gatewayUrl: undefined,
allowPluginFallback: params.allowPluginFallback,
clientDisplayName: `Telegram approval (${params.senderId})`,
});
}
beforeEach(() => {
approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy
.mockReset()
@@ -17,88 +49,49 @@ describe("resolveTelegramExecApproval", () => {
});
it("routes plugin approval ids through plugin.approval.resolve", async () => {
const { resolveTelegramExecApproval } = await import("./exec-approval-resolver.js");
await resolveTelegramExecApproval({
cfg: {} as never,
await invokeResolver({
approvalId: "plugin:abc123",
decision: "allow-once",
senderId: "9",
});
expect(approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy).toHaveBeenCalledWith({
cfg: {} as never,
expectApprovalGatewayCall({
approvalId: "plugin:abc123",
decision: "allow-once",
senderId: "9",
gatewayUrl: undefined,
allowPluginFallback: undefined,
clientDisplayName: "Telegram approval (9)",
});
});
it("falls back to plugin.approval.resolve when exec approval ids are unknown", async () => {
const { resolveTelegramExecApproval } = await import("./exec-approval-resolver.js");
await resolveTelegramExecApproval({
cfg: {} as never,
it.each([
"falls back to plugin.approval.resolve when exec approval ids are unknown",
"falls back to plugin.approval.resolve for structured approval-not-found errors",
])("%s", async () => {
await invokeResolver({
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
allowPluginFallback: true,
});
expect(approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy).toHaveBeenCalledWith({
cfg: {} as never,
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
gatewayUrl: undefined,
allowPluginFallback: true,
clientDisplayName: "Telegram approval (9)",
});
});
it("falls back to plugin.approval.resolve for structured approval-not-found errors", async () => {
const { resolveTelegramExecApproval } = await import("./exec-approval-resolver.js");
await resolveTelegramExecApproval({
cfg: {} as never,
expectApprovalGatewayCall({
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
allowPluginFallback: true,
});
expect(approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy).toHaveBeenCalledWith({
cfg: {} as never,
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
gatewayUrl: undefined,
allowPluginFallback: true,
clientDisplayName: "Telegram approval (9)",
});
});
it("passes fallback disablement through unchanged", async () => {
const { resolveTelegramExecApproval } = await import("./exec-approval-resolver.js");
await resolveTelegramExecApproval({
cfg: {} as never,
await invokeResolver({
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
});
expect(approvalGatewayRuntimeHoisted.resolveApprovalOverGatewaySpy).toHaveBeenCalledWith({
cfg: {} as never,
expectApprovalGatewayCall({
approvalId: "legacy-plugin-123",
decision: "allow-always",
senderId: "9",
gatewayUrl: undefined,
allowPluginFallback: undefined,
clientDisplayName: "Telegram approval (9)",
});
});
});