vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 10:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: drop duplicate zip extraction coverage

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-18 23:09:17 +01:00
parent 3455c857a0
commit cea60d603e
1 changed files with 0 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/agents/skills-install.download.test.ts
View File

@@ -34,14 +34,6 @@ async function fileExists(filePath: string): Promise<boolean> {
}
}
const SAFE_ZIP_BUFFER = Buffer.from(
"UEsDBAoAAAAAAMOJVlysKpPYAgAAAAIAAAAJAAAAaGVsbG8udHh0aGlQSwECFAAKAAAAAADDiVZcrCqT2AIAAAACAAAACQAAAAAAAAAAAAAAAAAAAAAAaGVsbG8udHh0UEsFBgAAAAABAAEANwAAACkAAAAAAA==",
"base64",
);
const STRIP_COMPONENTS_ZIP_BUFFER = Buffer.from(
"UEsDBAoAAAAAAMOJVlwAAAAAAAAAAAAAAAAIAAAAcGFja2FnZS9QSwMECgAAAAAAw4lWXKwqk9gCAAAAAgAAABEAAABwYWNrYWdlL2hlbGxvLnR4dGhpUEsBAhQACgAAAAAAw4lWXAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAQAAAAAAAAAHBhY2thZ2UvUEsBAhQACgAAAAAAw4lWXKwqk9gCAAAAAgAAABEAAAAAAAAAAAAAAAAAJgAAAHBhY2thZ2UvaGVsbG8udHh0UEsFBgAAAAACAAIAdQAAAFcAAAAAAA==",
"base64",
);
function buildEntry(name: string): SkillEntry {
const skillDir = path.join(workspaceDir, "skills", name);
const filePath = path.join(skillDir, "SKILL.md");
@@ -167,25 +159,7 @@ beforeEach(() => {
});
describe("installDownloadSpec extraction safety", () => {
it("extracts zip with stripComponents safely", async () => {
const entry = buildEntry("zip-good");
const targetDir = path.join(resolveSkillToolsRootDir(entry), "target");
mockArchiveResponse(new Uint8Array(STRIP_COMPONENTS_ZIP_BUFFER));
const result = await installDownloadSkill({
name: "zip-good",
url: "https://example.invalid/good.zip",
archive: "zip",
stripComponents: 1,
targetDir,
});
expect(result.ok).toBe(true);
expect(await fs.readFile(path.join(targetDir, "hello.txt"), "utf-8")).toBe("hi");
});
it("rejects targetDir escapes outside the per-skill tools root", async () => {
mockArchiveResponse(new Uint8Array(SAFE_ZIP_BUFFER));
const beforeFetchCalls = fetchWithSsrFGuardMock.mock.calls.length;
const result = await installDownloadSkill({