fix(qa): bound docker e2e log replay

This commit is contained in:
Vincent Koc
2026-06-23 13:26:06 +02:00
parent 9dbdefd43c
commit e856a24754
10 changed files with 120 additions and 16 deletions

View File

@@ -35,9 +35,9 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker OpenClaw bundle MCP tool availability smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
echo "OK"

View File

@@ -31,7 +31,7 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker commitments safety smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi

View File

@@ -35,9 +35,9 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker Crestodian first-run smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
echo "OK"

View File

@@ -35,9 +35,9 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker Crestodian planner fallback smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
echo "OK"

View File

@@ -35,9 +35,9 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker Crestodian rescue smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
echo "OK"

View File

@@ -40,16 +40,24 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker plugin binding command escape smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi
if ! node - "$RUN_LOG" <<'NODE'
const fs = require("node:fs");
const logPath = process.argv[2];
const text = fs
.readFileSync(logPath, "utf8")
.replace(/\x1B\[[0-?]*[ -/]*[@-~]/gu, "");
const scanBytes = 65536;
const stat = fs.statSync(logPath);
const length = Math.min(stat.size, scanBytes);
const buffer = Buffer.alloc(length);
const fd = fs.openSync(logPath, "r");
try {
fs.readSync(fd, buffer, 0, length, stat.size - length);
} finally {
fs.closeSync(fd);
}
const text = buffer.toString("utf8").replace(/\x1B\[[0-?]*[ -/]*[@-~]/gu, "");
if (!/(?:^|\n)\s*Tests\s+3 passed\b/u.test(text)) {
console.error("expected focused Vitest summary for exactly 3 passed tests");
@@ -59,7 +67,7 @@ if (!/(?:^|\n)\s*Tests\s+3 passed\b/u.test(text)) {
NODE
then
echo "Docker plugin binding command escape smoke did not stay focused"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit 1
fi

View File

@@ -32,7 +32,7 @@ set -e
if [ "$status" -ne 0 ]; then
echo "Docker session runtime context smoke failed"
cat "$RUN_LOG"
docker_e2e_print_log "$RUN_LOG"
exit "$status"
fi

View File

@@ -14,7 +14,46 @@ import {
} from "./lib/plugin-sdk-entries.mjs";
const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
const checkOnly = process.argv.includes("--check");
function usage() {
return `Usage: node scripts/plugin-sdk-surface-report.mjs [--check]
Reports plugin SDK export surface metadata.
Options:
--check Fail when SDK surface budgets are exceeded.
-h, --help Show this help.
`;
}
function parseArgs(argv) {
const args = { check: false, help: false };
for (const arg of argv) {
if (arg === "--check") {
args.check = true;
continue;
}
if (arg === "--help" || arg === "-h") {
args.help = true;
continue;
}
throw new Error(`Unknown plugin SDK surface report option: ${arg}`);
}
return args;
}
let cliArgs;
try {
cliArgs = parseArgs(process.argv.slice(2));
} catch (error) {
console.error(error instanceof Error ? error.message : String(error));
process.exit(1);
}
if (cliArgs.help) {
process.stdout.write(usage());
process.exit(0);
}
const checkOnly = cliArgs.check;
const publicEntrypointSet = new Set(publicPluginSdkEntrypoints);
const localOnlyEntrypointSet = new Set(privateLocalOnlyPluginSdkEntrypoints);
const deprecatedPublicEntrypointSet = new Set(deprecatedPublicPluginSdkEntrypoints);

View File

@@ -56,6 +56,14 @@ const QR_IMPORT_DOCKER_E2E_PATH = "scripts/e2e/qr-import-docker.sh";
const MULTI_NODE_UPDATE_DOCKER_E2E_PATH = "scripts/e2e/multi-node-update-docker.sh";
const BUNDLED_PLUGIN_INSTALL_UNINSTALL_E2E_PATH =
"scripts/e2e/bundled-plugin-install-uninstall-docker.sh";
const AGENT_BUNDLE_MCP_TOOLS_DOCKER_E2E_PATH =
"scripts/e2e/agent-bundle-mcp-tools-docker.sh";
const COMMITMENTS_SAFETY_DOCKER_E2E_PATH = "scripts/e2e/commitments-safety-docker.sh";
const CRESTODIAN_FIRST_RUN_DOCKER_E2E_PATH = "scripts/e2e/crestodian-first-run-docker.sh";
const CRESTODIAN_PLANNER_DOCKER_E2E_PATH = "scripts/e2e/crestodian-planner-docker.sh";
const CRESTODIAN_RESCUE_DOCKER_E2E_PATH = "scripts/e2e/crestodian-rescue-docker.sh";
const SESSION_RUNTIME_CONTEXT_DOCKER_E2E_PATH =
"scripts/e2e/session-runtime-context-docker.sh";
const BUNDLED_PLUGIN_INSTALL_UNINSTALL_SWEEP_PATH =
"scripts/e2e/lib/bundled-plugin-install-uninstall/sweep.sh";
const BUNDLED_PLUGIN_INSTALL_UNINSTALL_PROBE_PATH =
@@ -3360,6 +3368,31 @@ output="$(cat "$sampler_log")"
}
});
it("keeps captured Docker E2E run log replay bounded", () => {
for (const path of [
AGENT_BUNDLE_MCP_TOOLS_DOCKER_E2E_PATH,
COMMITMENTS_SAFETY_DOCKER_E2E_PATH,
CRESTODIAN_FIRST_RUN_DOCKER_E2E_PATH,
CRESTODIAN_PLANNER_DOCKER_E2E_PATH,
CRESTODIAN_RESCUE_DOCKER_E2E_PATH,
PLUGIN_BINDING_COMMAND_ESCAPE_DOCKER_E2E_PATH,
SESSION_RUNTIME_CONTEXT_DOCKER_E2E_PATH,
]) {
const runner = readFileSync(path, "utf8");
expect(runner, path).toContain('RUN_LOG="$(mktemp');
expect(runner, path).toContain('docker_e2e_print_log "$RUN_LOG"');
expect(runner, path).not.toContain('cat "$RUN_LOG"');
}
const pluginBinding = readFileSync(PLUGIN_BINDING_COMMAND_ESCAPE_DOCKER_E2E_PATH, "utf8");
expect(pluginBinding).toContain("const scanBytes = 65536");
expect(pluginBinding).toContain("fs.statSync(logPath)");
expect(pluginBinding).toContain("fs.readSync(fd, buffer, 0, length, stat.size - length)");
expect(pluginBinding).not.toContain("process.env.OPENCLAW_DOCKER_E2E_LOG_PRINT_BYTES");
expect(pluginBinding).not.toContain('readFileSync(logPath, "utf8")');
});
it("keeps Open WebUI Docker E2E resource-guarded", () => {
const runner = readFileSync(OPENWEBUI_DOCKER_E2E_PATH, "utf8");

View File

@@ -27,6 +27,30 @@ function readDefaultPublicFunctionExportBudget() {
}
describe("plugin SDK surface report", () => {
it("rejects unknown CLI options before collecting SDK stats", () => {
const result = spawnSync(process.execPath, ["scripts/plugin-sdk-surface-report.mjs", "--chekc"], {
cwd: process.cwd(),
encoding: "utf8",
});
expect(result.status).toBe(1);
expect(result.stdout).toBe("");
expect(result.stderr.trim()).toBe("Unknown plugin SDK surface report option: --chekc");
expect(result.stderr).not.toContain("at ");
});
it("prints help before collecting SDK stats", () => {
const result = spawnSync(process.execPath, ["scripts/plugin-sdk-surface-report.mjs", "--help"], {
cwd: process.cwd(),
encoding: "utf8",
});
expect(result.status).toBe(0);
expect(result.stdout).toContain("Usage: node scripts/plugin-sdk-surface-report.mjs");
expect(result.stderr).toBe("");
expect(result.stdout).not.toContain("all SDK entrypoints:");
});
it("rejects loose numeric budget env vars before collecting SDK stats", () => {
const result = runSurfaceReport({
OPENCLAW_PLUGIN_SDK_MAX_PUBLIC_EXPORTS: "1e9",