vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 07:40:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(oauth): make codex tls preflight advisory

Browse Source
This commit is contained in:
Vincent Koc
2026-04-17 10:23:16 -07:00
parent 76c8db3766
commit f513bae67e
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/provider-openai-codex-oauth.test.ts
View File

@@ -238,7 +238,7 @@ describe("loginOpenAICodexOAuth", () => {
expect(prompter.note).not.toHaveBeenCalledWith("tls fix", "OAuth prerequisites");
});
it("fails early with actionable message when TLS preflight fails", async () => {
it("surfaces TLS preflight guidance but still attempts OAuth login", async () => {
mocks.runOpenAIOAuthTlsPreflight.mockResolvedValue({
ok: false,
kind: "tls-cert",
@@ -246,6 +246,14 @@ describe("loginOpenAICodexOAuth", () => {
message: "unable to get local issuer certificate",
});
mocks.formatOpenAIOAuthTlsPreflightFix.mockReturnValue("Run brew postinstall openssl@3");
const creds = {
provider: "openai-codex" as const,
access: "access-token",
refresh: "refresh-token",
expires: Date.now() + 60_000,
email: "user@example.com",
};
mocks.loginOpenAICodex.mockResolvedValue(creds);
const { prompter } = createPrompter();
const runtime = createRuntime();
@@ -257,10 +265,11 @@ describe("loginOpenAICodexOAuth", () => {
isRemote: false,
openUrl: async () => {},
}),
).rejects.toThrow("unable to get local issuer certificate");
).resolves.toEqual(creds);
expect(mocks.loginOpenAICodex).not.toHaveBeenCalled();
expect(runtime.error).toHaveBeenCalledWith("Run brew postinstall openssl@3");
expect(mocks.loginOpenAICodex).toHaveBeenCalledOnce();
expect(runtime.log).toHaveBeenCalledWith("Run brew postinstall openssl@3");
expect(runtime.error).not.toHaveBeenCalledWith("Run brew postinstall openssl@3");
expect(prompter.note).toHaveBeenCalledWith(
"Run brew postinstall openssl@3",
"OAuth prerequisites",

3
src/plugins/provider-openai-codex-oauth.ts
View File

@@ -25,9 +25,8 @@ export async function loginOpenAICodexOAuth(params: {
const preflight = await runOpenAIOAuthTlsPreflight();
if (!preflight.ok && preflight.kind === "tls-cert") {
const hint = formatOpenAIOAuthTlsPreflightFix(preflight);
runtime.error(hint);
runtime.log(hint);
await prompter.note(hint, "OAuth prerequisites");
throw new Error(preflight.message);
}
await prompter.note(