vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 10:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agents): narrow glm- silent-overflow detection to bare model ids

Browse Source
This commit is contained in:
openperf
2026-05-02 20:31:11 +08:00
parent 0d4d304e0f
commit f90f341092
2 changed files with 24 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/agents/pi-settings.test.ts
View File

@@ -377,15 +377,25 @@ describe("isSilentOverflowProneModel", () => {
// openclaw#75799 reporter's setup: an OpenAI-compatible in-house gateway
// exposing Zhipu's GLM family directly (model id `glm-5.1`, no `z-ai/`
// qualifier, custom baseUrl that is not api.z.ai). Catch the GLM family
// name with or without a path namespace so deploys that proxy it under
// their own provider name still hit the guard.
it("flags glm- model ids regardless of path namespace", () => {
// qualifier, custom baseUrl that is not api.z.ai). Catch the bare GLM
// family name so direct gateway deployments hit the guard.
it("flags bare glm- model ids without a namespace prefix", () => {
expect(isSilentOverflowProneModel({ provider: "custom", modelId: "glm-5.1" })).toBe(true);
expect(isSilentOverflowProneModel({ provider: "custom", modelId: "glm-4.7" })).toBe(true);
});
// Detection is intentionally narrow to z.ai-style accounting. Namespaced GLM
// ids that route through providers with their own overflow accounting must
// NOT be flagged — those hosts may not exhibit the z.ai silent-overflow
// shape, and disabling Pi auto-compaction for them would over-broaden the
// kill surface beyond the reproducible repro.
it("does not flag namespaced GLM ids routed through non-z.ai hosts", () => {
expect(
isSilentOverflowProneModel({ provider: "ollama", modelId: "ollama/glm-5.1:cloud" }),
).toBe(true);
).toBe(false);
expect(
isSilentOverflowProneModel({ provider: "opencode-go", modelId: "opencode-go/glm-5.1" }),
).toBe(false);
});
// pi-ai's overflow.ts only documents z.ai as the silent-overflow style. We

17
src/agents/pi-settings.ts
View File

@@ -131,12 +131,14 @@ export function applyPiCompactionSettingsFromConfig(params: {
* provider call (openclaw#75799).
*
* True on any of: `zai-native` endpoint class, normalized provider id `zai`,
* a `z-ai/` / `openrouter/z-ai/` model-id namespace prefix, or a `glm-` model
* name (with or without a path namespace) — covering in-house gateways and
* ollama-style deploys that expose Zhipu's GLM family directly without a
* `z-ai/` qualifier. Intentionally narrow to z.ai-style accounting; other
* providers documented as silently truncating are not added without a
* reproducible repro.
* a `z-ai/` / `openrouter/z-ai/` model-id namespace prefix, or a bare `glm-`
* model id (no namespace prefix) — the latter covers in-house gateways that
* expose Zhipu's GLM family directly without a `z-ai/` qualifier. Intentionally
* narrow: namespaced GLM ids that route through other providers (e.g.
* `ollama/glm-*`, `opencode-go/glm-*`) are NOT included because their hosts
* have their own overflow accounting and may not exhibit the z.ai silent-
* overflow shape. Other providers documented as silently truncating are not
* added without a reproducible repro.
*/
export function isSilentOverflowProneModel(model: {
provider?: string | null;
@@ -157,8 +159,7 @@ export function isSilentOverflowProneModel(model: {
if (
normalized.startsWith("z-ai/") ||
normalized.startsWith("openrouter/z-ai/") ||
normalized.startsWith("glm-") ||
normalized.includes("/glm-")
normalized.startsWith("glm-")
) {
return true;
}