Commit Graph

30853 Commits

Author SHA1 Message Date
Vincent Koc
ed1744bcaa test(heartbeat): cover isolated cron event consumption 2026-04-12 17:55:36 +01:00
zhouhe-xydt
879bb5dd91 fix(memory-wiki): support Unicode characters in slugifyWikiSegment (#64742)
* fix(memory-wiki): support Unicode characters in slugifyWikiSegment

Replace ASCII-only regex with Unicode-aware regex to preserve CJK,
Cyrillic, Arabic, and other non-ASCII characters in wiki slugs.

Fixes #64620

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test(memory-wiki): cover Unicode slug regressions

* fix(memory-wiki): preserve combining marks in slugs

* fix(memory-wiki): cap composed source filenames

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:54:41 +01:00
Vincent Koc
68a64a14d9 test(gateway): share close handler deps 2026-04-12 17:45:46 +01:00
Nimrod Gutman
26dbc3da15 fix(agents): isolate skills tests from personal home (#65456) 2026-04-12 19:44:50 +03:00
Peter Steinberger
b23f56fa8c fix: restore media understanding attempt outcome export 2026-04-12 17:44:16 +01:00
MrBrain
346e38e275 fix(memory-core): isolate dreaming narrative sessions per workspace (#61674)
* fix(memory-core): isolate dreaming narrative sessions per workspace

* chore(changelog): add narrative isolation note

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:39:28 +01:00
Mason Huang
24d769449d feat(skills): WIP-add secret-scanning-maintainer skill (#65417)
* feat(skills): add secret-scanning-maintainer skill

Add a maintainer-only skill for handling GitHub Secret Scanning alerts.
Covers issue_comment, issue_body, pull_request_body, and commit leak
types with redaction, history purge (delete+recreate for comments),
author notification, and alert resolution workflows.

* fix(skills): harden secret-scanning-maintainer based on security review

- Remove all secret value fragments from redaction markers (type-only)
- Remove alert URLs and partial secret previews from public comments
- Use temp files with heredoc for all gh api body content (shell injection)
- Add rule: never print raw API responses containing secrets to stdout
- Notification comments now only reference secret type, no value hints

Addresses 4 of 6 security findings from PR review:
1. Over-permissive redaction → type-only markers
3. Public partial preview + alert URL → removed from comments
4. Shell quoting risk → heredoc + temp file pattern
5. Stdout secret exposure → jq-only extraction rule

Findings #2 (revoked without rotation) and #6 (public playbook) are
accepted as-is with documented rationale.

* fix(skills): address all bot review findings on secret-scanning skill

Addresses findings from Codex, Greptile, and Aisle bot reviews:

- Add pull_request_comment and pull_request_review_comment to location
  type routing table (was being skipped as unsupported) [Codex P1]
- Use hide_secret=true on alert fetch to prevent plaintext in terminal
  [Codex P1]
- Add jq filtering on all fetch commands to avoid printing .body or
  .secret to stdout [Codex P1, Aisle Medium]
- Skip PATCH before DELETE for comments — PATCH creates an unnecessary
  edit history revision exposing plaintext [Greptile P1]
- Use mktemp for all temp files instead of fixed /tmp paths [Aisle Medium]
- Branch notification template by location type: comment says "removed
  and replaced", body says "redacted in place", commit says "committed"
  [Greptile P1]
- Bump userContentEdits(first: 10) to first: 50 to reduce truncation
  risk [Greptile P2]
- Fix batch listing jq query to use .html_url instead of
  .first_location_detected.html_url [Codex P2]
- Use heredoc + temp file for comment recreation (was inline -f)
  [Codex P1]
- Remove alert URLs from public notification templates [Codex P1]

* feat(skills): extract secret-scanning operations into reusable script

Add scripts/secret-scanning.mjs with subcommands: fetch-alert,
fetch-content, redact-body, delete-comment, recreate-comment, notify,
resolve, list-open, summary.

Security enforcements now live in the script (not agent memory):
- hide_secret=true on all alert fetches
- mktemp with random UUIDs for all temp files
- -F body=@file for all body uploads
- .secret and .body never printed to stdout
- notification templates branched by location type

SKILL.md simplified from ~370 lines to ~170 lines — now a decision
guide that references script commands instead of inline gh api calls.

* fix(skills): enforce script summary output as final summary

Agent was rewriting the summary table without URLs. Make SKILL.md
explicit: the script output IS the final summary, do not reformat it.

* fix(skills): add summary output markers for verbatim rendering

Script summary now outputs ---BEGIN SUMMARY--- / ---END SUMMARY---
markers. SKILL.md instructs agent to output the content between markers
verbatim, preventing reformatting that drops URLs.

* fix(skills): address latest bot review findings on script

- Restrict temp file permissions to 0600 (owner-only) [Codex P1]
- Add --slurp to list-open and fetch-alert locations for correct
  multi-page JSON parsing [Codex P1, Codex P2]
- Use commit_url/blob_url fallback for commit location URLs [Codex P2]
- Add --paginate to locations fetch [Codex P2]
2026-04-13 00:39:17 +08:00
Vincent Koc
12d351b79c fix(ui): hide synthetic transcript-repair history messages (#65458) 2026-04-12 17:35:30 +01:00
Sergiusz
079eb18bf7 fix: harden dreaming narrative session cleanup (#65320)
* fix: harden dreaming narrative session cleanup

* fix(memory-core): harden narrative cleanup

* fix(memory-core): preserve fallback narrative sessions

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:33:47 +01:00
Pengfei Ni
aff8a0c0e7 fix(config): resolve CLI command aliases against parent plugin in plugins.allow (#64748) (#64779)
* fix(config): resolve CLI command aliases against parent plugin in plugins.allow (#64748)

The CLI allow guard checked command names (e.g. 'wiki') directly against
plugins.allow, missing the parent plugin ('memory-wiki'). Additionally,
memory-wiki did not declare 'wiki' as a commandAlias, so doctor --fix
would remove it as stale.

- Add commandAliases entry for 'wiki' in memory-wiki plugin manifest
- Check parent plugin ID in the CLI fallback allow guard
- Add tests for both allow and deny cases

* fix(cli): inject manifest registry for alias diagnostics

* Update CHANGELOG.md

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:32:11 +01:00
Leonard Sellem
c545e4605e fix(memory-wiki): pass app config into CLI metadata registrar (#65012)
* fix(memory-wiki): pass config into cli metadata registrar

* fix(memory-wiki): use cli context config for metadata registrar

* docs(changelog): note memory-wiki cli metadata fix

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:30:54 +01:00
Vincent Koc
7518b8d339 test(gateway): share allowlist node helpers 2026-04-12 17:26:31 +01:00
Vincent Koc
b7b3846793 feat(plugins): narrow channel loads from manifests (#65429)
* feat(plugins): narrow channel loads from manifests

* fix(plugins): harden channel owner activation trust

* fix(plugins): preserve empty channel scopes

* fix(plugins): honor channel-owner policy gates

* fix(plugins): keep channel setup and scope fallbacks correct

* fix(plugins): keep channel trust tied to source config
2026-04-12 17:24:15 +01:00
Peter Steinberger
50fcdb36a8 fix: preserve prompt budget for small context models 2026-04-12 17:16:37 +01:00
Vincent Koc
0b8f09819f fix(media): use exported decision outcome type 2026-04-12 17:13:27 +01:00
Vincent Koc
df1a82f6c1 test(gateway): share auth-profile ref fixture 2026-04-12 17:11:12 +01:00
Sergio Cadavid
51f0037e61 docs(memory-wiki): add QMD bridge recipe (#63165)
* docs(memory-wiki): add qmd bridge recipe

* docs(memory-wiki): remove restrictive allowlist from bridge example

* docs(changelog): note memory-wiki bridge recipe

* Apply suggestion from @greptile-apps[bot]

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* Update memory-wiki.md

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
2026-04-12 17:10:49 +01:00
Vincent Koc
88dfc6e7b6 test(gateway): share hook session routing helper 2026-04-12 17:09:23 +01:00
Vincent Koc
43cb94a39a fix(doctor): preserve discord streaming downgrade compatibility 2026-04-12 17:09:08 +01:00
Daniel Alkurdi
1f0431cd11 fix(media): surface OpenAI audio transcription failures (#65096)
* fix(media): surface audio transcription provider failures

* fix(media): prefer failed reasons in surfaced errors

* fix(media): import attempt outcome type

* fix(media): guard malformed decision arrays

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 17:05:18 +01:00
Vincent Koc
d46f684898 test(agents): fix tsgo typing regressions 2026-04-12 17:02:24 +01:00
Vincent Koc
3bb69edf58 test(gateway): share browser origin rejection helper 2026-04-12 17:01:43 +01:00
Peter Steinberger
c146738996 fix: stabilize subagent cleanup retries 2026-04-12 16:59:27 +01:00
eric-fr4
ad826ea450 Fix WhatsApp media sends when mediaUrl is empty but mediaUrls is populated (#64394)
* Fix WhatsApp media fallback

Accept the first mediaUrls entry when mediaUrl is empty so outbound WhatsApp sends do not silently downgrade media messages to text.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(changelog): credit WhatsApp mediaUrls fallback

* fix(changelog): restore 2026.4.10 release block

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:58:40 +01:00
Vincent Koc
2de988ae4b test(gateway): share temp home env setup 2026-04-12 16:56:06 +01:00
Vincent Koc
786de3eca2 fix(gateway): keep tick broadcasts non-droppable (#65436)
* fix(gateway): keep tick broadcasts non-droppable

* Update CHANGELOG.md
2026-04-12 16:53:34 +01:00
Vincent Koc
3cf0dda22a test(gateway): share node pairing auth helpers 2026-04-12 16:52:06 +01:00
Edder Talmor
5f92094d51 fix: gracefully handle missing QA scenario pack in npm distributions (closes #65082) (#65118)
* fix: allow built-in chat commands to bypass plugins.allow check (closes #65083)

The 'commands' CLI command is a built-in chat command registered in the
chat commands registry, not a plugin-backed command. When plugins.allow
is configured, the error message incorrectly suggests adding 'commands'
to plugins.allow, which produces a second error because no 'commands'
plugin exists.

Check if the command has a plugin entry or manifest alias before
suggesting plugins.allow. Built-in commands without plugin entries
now proceed normally instead of showing misleading errors.

* fix: gracefully handle missing QA scenario pack in npm distributions (closes #65082)

The completion cache update fails with a fatal error when the
qa/scenarios/index.md file is not present in the installed npm package,
even though the directory is listed in package.json "files".

Instead of throwing an error, return an empty QA scenario pack with
default agent identity. This allows completion cache updates to succeed
while QA scenarios remain unavailable in the npm distribution.

The QA scenario pack is primarily used for internal testing and QA
automation — it is not critical for end-user functionality.

* revert: remove unintended run-main.ts changes from PR #65118

The scenario-catalog.ts fix is the correct change for this PR.
The run-main.ts changes were accidentally included and cause a
regression in plugins.allow error handling.

* fix(qa): tolerate missing packaged scenario config

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:50:58 +01:00
Yanhu
3ef8f0edd8 fix(dreaming): include timezone label in diary timestamps (#65057)
Dream diary entries in DREAMS.md and the Control UI show bare
timestamps without any timezone indicator. When users have not
configured a timezone, timestamps are rendered in UTC but appear to be
local time, causing confusion.

Add timeZoneName: "short" to the Intl.DateTimeFormat options in
formatNarrativeDate so timestamps always include a timezone
abbreviation (e.g. "9:46 PM UTC" or "2:46 PM PDT").

Fixes #65027
2026-04-12 16:48:40 +01:00
Vincent Koc
156ee544ed test(agents): share notify heartbeat wake helper 2026-04-12 16:43:39 +01:00
Coy Geek
4938b2cc43 fix: Provider-supplied OAuth URLs inject Windows cmd.exe via openUrl (#64161)
* fix: harden Windows browser URL opening

Use explorer.exe directly for OAuth/browser launch on Windows so provider-supplied URLs are never parsed through cmd.exe metacharacter rules.

* fix: harden Windows browser URL opening

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:42:24 +01:00
pradeep7127
5fde14b844 fix(plugins): exempt dreaming engine from memory slot fast-path in loader (#65411)
* fix(plugins): exempt dreaming engine from memory slot fast-path in loader

* fix(plugins): handle dreaming engine as slot + add tests for slot coexistence

* fix(plugins): narrow dreaming sidecar loading

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:41:25 +01:00
Vincent Koc
559de69488 test(agents): share ollama auth fixture 2026-04-12 16:40:28 +01:00
CodeForgeNet
10cd000f60 gateway: always send idempotencyKey on plugin subagent run (#65354)
* gateway: always send idempotencyKey on plugin subagent run

* docs(changelog): add dreaming idempotency entry

* Update CHANGELOG.md

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:39:26 +01:00
Vincent Koc
4b761f6e23 test(agents): share gemini model fixture 2026-04-12 16:38:25 +01:00
neo1027144
7d9e349129 [AI-assisted] fix(dreaming): use host local timezone for diary timestamps (#65034)
* fix(dreaming): use host local timezone when timezone is not configured

When `memory.dreaming.timezone` is unset, `formatNarrativeDate()`
previously defaulted to UTC, causing diary timestamps in DREAMS.md and
the Control UI to display UTC time as though it were the user's local
time. For example, a PDT user seeing 9:46 PM instead of the correct
2:46 PM.

Drop the UTC fallback so `Intl.DateTimeFormat` automatically uses the
host's timezone when no explicit timezone is provided. Users who have
set `agents.defaults.userTimezone` or `dreaming.timezone` are
unaffected.

Fixes #65027

* docs(changelog): add dreaming timezone entry

* Update CHANGELOG.md

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:38:18 +01:00
Daniel Alkurdi
b8c95e5825 fix(memory-core): wake managed dreaming jobs immediately (#65053)
* fix(memory-core): wake managed dreaming jobs immediately

* docs(changelog): add dreaming wake entry

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-04-12 16:37:21 +01:00
Vincent Koc
d0f090e188 test(agents): share exec preflight race helper 2026-04-12 16:36:46 +01:00
Vincent Koc
93abf5ee4d test(agents): share websocket tool followup helper 2026-04-12 16:35:01 +01:00
Alex Navarro
f3b636481f fix(gateway): reject known-weak example auth credentials at startup (#64586) 2026-04-12 16:33:05 +01:00
Vincent Koc
4904e15349 test(agents): share anthropic vertex adc fixture 2026-04-12 16:32:26 +01:00
Vincent Koc
a19e492fb3 test(agents): trim subagent spawn config duplication 2026-04-12 16:30:31 +01:00
Vincent Koc
48f74a599e test(agents): share bundle mcp runtime fixture 2026-04-12 16:28:27 +01:00
Peter Steinberger
03904a7e9c test(agents): update Matrix ACP delivery expectation 2026-04-12 16:22:58 +01:00
Vincent Koc
6a189eec0b fix(plugins): centralize explicit plugin scope handling (#65298)
* fix(plugins): centralize explicit plugin scope handling

* fix(plugins): preserve explicit empty web scopes

* fix(plugins): preserve runtime web provider scopes without config

* fix(plugins): preserve web provider runtime filtering

* fix(plugins): preserve scoped web runtime fallback

* fix(plugins): harden plugin scope normalization
2026-04-12 16:16:37 +01:00
Peter Steinberger
659bcc5e5b fix: tighten codex app-server lifecycle 2026-04-12 16:15:01 +01:00
Peter Steinberger
485f4167e1 test(auto-reply): update WhatsApp group prompt expectation 2026-04-12 16:13:18 +01:00
Peter Steinberger
23e50859eb test(e2e): align release harness coverage 2026-04-12 16:08:12 +01:00
Peter Steinberger
6c45d78e07 fix(channels): await external plugin preload 2026-04-12 16:08:03 +01:00
Peter Steinberger
bc44ce2c8e fix(gateway): filter assistant phase history 2026-04-12 16:07:55 +01:00