test: clarify feishu validation assertions

This commit is contained in:
Peter Steinberger
2026-05-08 08:58:25 +01:00
parent 29689c62d0
commit 2c7c57d519
2 changed files with 5 additions and 9 deletions

View File

@@ -315,9 +315,7 @@ describe("FeishuConfigSchema defaultAccount", () => {
expect(result.success).toBe(false);
if (!result.success) {
expect(result.error.issues.some((issue) => issue.path.join(".") === "defaultAccount")).toBe(
true,
);
expect(result.error.issues.map((issue) => issue.path.join("."))).toContain("defaultAccount");
}
});
});

View File

@@ -47,15 +47,13 @@ describe("Feishu security audit findings", () => {
},
])("$name", ({ cfg, expectedFinding, expectedNoFinding }) => {
const findings = collectFeishuSecurityAuditFindings({ cfg });
const findingKeys = findings.map((finding) => `${finding.checkId}:${finding.severity}`);
const checkIds = findings.map((finding) => finding.checkId);
if (expectedFinding) {
expect(
findings.some(
(finding) => finding.checkId === expectedFinding && finding.severity === "warn",
),
).toBe(true);
expect(findingKeys).toContain(`${expectedFinding}:warn`);
}
if (expectedNoFinding) {
expect(findings.some((finding) => finding.checkId === expectedNoFinding)).toBe(false);
expect(checkIds).not.toContain(expectedNoFinding);
}
});
});