refactor(plugins): drop provider discovery alias

This commit is contained in:
Vincent Koc
2026-04-26 18:19:05 -07:00
committed by GitHub
parent eed7b13b62
commit 6a5ecb955c
2 changed files with 5 additions and 12 deletions

View File

@@ -10,6 +10,7 @@ import {
runProviderCatalog,
runProviderStaticCatalog,
} from "./provider-discovery.js";
import * as providerDiscoveryModule from "./provider-discovery.js";
import { cleanupTrackedTempDirs, makeTrackedTempDir } from "./test-helpers/fs-fixtures.js";
import type { ProviderCatalogResult, ProviderDiscoveryOrder, ProviderPlugin } from "./types.js";
@@ -179,6 +180,10 @@ describe("resolveInstalledPluginProviderContributionIds", () => {
}
});
it("does not keep exporting the ambiguous runtime-discovery alias", () => {
expect(Object.keys(providerDiscoveryModule)).not.toContain("resolvePluginDiscoveryProviders");
});
it("reads provider ids from the installed plugin index without importing runtime entries", () => {
const candidate = createProviderContributionCandidate({
pluginId: "demo",

View File

@@ -79,18 +79,6 @@ export async function resolveRuntimePluginDiscoveryProviders(
.filter((provider) => resolveProviderCatalogOrderHook(provider));
}
/**
* @deprecated Runtime-backed provider discovery must be explicit at call sites.
* Use `resolveRuntimePluginDiscoveryProviders(...)` for paths that intentionally
* import provider plugin runtime, or `resolveInstalledPluginProviderContributionIds(...)`
* for cold installed-index reads.
*/
export async function resolvePluginDiscoveryProviders(
params: ResolveRuntimePluginDiscoveryProvidersParams,
): Promise<ProviderPlugin[]> {
return resolveRuntimePluginDiscoveryProviders(params);
}
export function groupPluginDiscoveryProvidersByOrder(
providers: ProviderPlugin[],
): Record<ProviderDiscoveryOrder, ProviderPlugin[]> {