test: tighten task empty array assertions

This commit is contained in:
Shakker
2026-05-09 05:13:55 +01:00
parent 8cd978c02a
commit 7b73faaa7e
12 changed files with 26 additions and 26 deletions

View File

@@ -132,7 +132,7 @@ describe("runCronIsolatedAgentTurn cron delivery awareness", () => {
expect(result.status).toBe("ok");
expect(result.delivered).toBe(true);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
});
});
});

View File

@@ -53,7 +53,7 @@ describe("resolveCronFallbacksOverride", () => {
model: "google/gemini-2.0-flash",
}),
}),
).toEqual([]);
).toStrictEqual([]);
});
it("lets payload fallbacks override the configured fallback policy", () => {
@@ -68,7 +68,7 @@ describe("resolveCronFallbacksOverride", () => {
fallbacks: [],
}),
}),
).toEqual([]);
).toStrictEqual([]);
});
it("leaves the default model path to the fallback runner when no payload model is set", () => {

View File

@@ -220,7 +220,7 @@ describe("runCronIsolatedAgentTurn — cron model override forwarding (#58065)",
// With the fix, the shared override helper resolves an explicit empty
// list here: no configured fallback chain, and no silent agent-primary
// append on retry.
expect(capturedFallbacksOverride).toEqual([]);
expect(capturedFallbacksOverride).toStrictEqual([]);
});
it("preserves default fallback chain for cron payload model overrides", async () => {

View File

@@ -540,7 +540,7 @@ describe("normalizeCronJobCreate", () => {
}) as unknown as Record<string, unknown>;
const payload = normalized.payload as Record<string, unknown>;
expect(payload.toolsAllow).toEqual([]);
expect(payload.toolsAllow).toStrictEqual([]);
expect(validateCronAddParams(normalized)).toBe(true);
});
@@ -799,7 +799,7 @@ describe("normalizeCronJobPatch", () => {
const payload = normalized.payload as Record<string, unknown>;
expect(payload.kind).toBe("agentTurn");
expect(payload.fallbacks).toEqual([]);
expect(payload.fallbacks).toStrictEqual([]);
});
it("preserves empty toolsAllow lists so patches can disable all tools", () => {
@@ -811,7 +811,7 @@ describe("normalizeCronJobPatch", () => {
const payload = normalized.payload as Record<string, unknown>;
expect(payload.kind).toBe("agentTurn");
expect(payload.toolsAllow).toEqual([]);
expect(payload.toolsAllow).toStrictEqual([]);
expect(validateCronUpdateParams({ id: "job-1", patch: normalized })).toBe(true);
});

View File

@@ -126,7 +126,7 @@ describe("cron run log", () => {
durationMs: 100,
}),
]);
expect(readCronRunLogEntriesSync(path.join(dir, "runs", "missing.jsonl"))).toEqual([]);
expect(readCronRunLogEntriesSync(path.join(dir, "runs", "missing.jsonl"))).toStrictEqual([]);
});
});
@@ -223,7 +223,7 @@ describe("cron run log", () => {
limit: 10,
jobId: "b",
});
expect(wrongFilter).toEqual([]);
expect(wrongFilter).toStrictEqual([]);
});
});
@@ -310,7 +310,7 @@ describe("cron run log", () => {
query: "-100",
})
).entries,
).toEqual([]);
).toStrictEqual([]);
});
});

View File

@@ -1070,7 +1070,7 @@ describe("cron service timer regressions", () => {
await onTimer(state);
expect(state.store?.jobs).toEqual([]);
expect(state.store?.jobs).toStrictEqual([]);
expect(log.warn).not.toHaveBeenCalledWith(
expect.anything(),
"cron: applyOutcomeToStoredJob — job not found after forceReload, result discarded",
@@ -1124,7 +1124,7 @@ describe("cron service timer regressions", () => {
await onTimer(state);
expect(state.store?.jobs).toEqual([]);
expect(state.store?.jobs).toStrictEqual([]);
expect(log.warn).toHaveBeenCalledWith(
{ jobId: failedJob.id },
"cron: applyOutcomeToStoredJob — job not found after forceReload, result discarded",

View File

@@ -61,7 +61,7 @@ describe("task boundaries", () => {
}
}
}
expect(offenders).toEqual([]);
expect(offenders).toStrictEqual([]);
});
it("keeps direct task-flow-registry imports behind approved task-flow access seams", () => {

View File

@@ -358,7 +358,7 @@ describe("task-executor", () => {
});
expect(created.parentFlowId).toBeUndefined();
expect(listTaskFlowRecords()).toEqual([]);
expect(listTaskFlowRecords()).toStrictEqual([]);
});
});

View File

@@ -94,6 +94,6 @@ describe("task flow owner access", () => {
listTaskFlowsForOwner({
callerOwnerKey: "agent:main:other",
}),
).toEqual([]);
).toStrictEqual([]);
});
});

View File

@@ -93,7 +93,7 @@ describe("task-flow-registry audit", () => {
},
});
expect(listTaskFlowAuditFindings()).toEqual([]);
expect(listTaskFlowAuditFindings()).toStrictEqual([]);
});
it("detects stuck managed flows and missing blocked tasks", async () => {

View File

@@ -471,7 +471,7 @@ describe("task-registry maintenance issue #60299", () => {
error: "backing session missing",
}),
]);
expect(getInspectableActiveTaskRestartBlockers()).toEqual([]);
expect(getInspectableActiveTaskRestartBlockers()).toStrictEqual([]);
expect(await runTaskRegistryMaintenance()).toMatchObject({ reconciled: 1 });
expect(currentTasks.get(task.taskId)).toMatchObject({ status: "lost" });
});

View File

@@ -808,7 +808,7 @@ describe("task-registry", () => {
}),
),
);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
});
});
@@ -1098,7 +1098,7 @@ describe("task-registry", () => {
}),
),
);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
expect(hasPendingHeartbeatWake()).toBe(false);
});
});
@@ -1546,7 +1546,7 @@ describe("task-registry", () => {
expect(getTaskById(task.taskId)).toMatchObject({
status: "running",
});
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
});
});
@@ -1978,7 +1978,7 @@ describe("task-registry", () => {
cleanupStamped: 0,
pruned: 1,
});
expect(listTaskRecords()).toEqual([]);
expect(listTaskRecords()).toStrictEqual([]);
});
});
@@ -2117,7 +2117,7 @@ describe("task-registry", () => {
startTaskRegistryMaintenance();
await vi.advanceTimersByTimeAsync(5_000);
await flushAsyncWork();
expect(unhandled).toEqual([]);
expect(unhandled).toStrictEqual([]);
} finally {
process.off("unhandledRejection", onUnhandledRejection);
}
@@ -2528,7 +2528,7 @@ describe("task-registry", () => {
});
vi.advanceTimersByTime(10);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
expect(hoisted.sendMessageMock).not.toHaveBeenCalled();
emitAgentEvent({
@@ -2548,7 +2548,7 @@ describe("task-registry", () => {
content: "Background task done: ACP background task (run run-quie).",
}),
);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
relay.dispose();
vi.useRealTimers();
});
@@ -2601,7 +2601,7 @@ describe("task-registry", () => {
"Background task failed: ACP background task (run run-fail). Permission denied by ACP runtime",
}),
);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
});
});
@@ -2662,7 +2662,7 @@ describe("task-registry", () => {
}),
);
expect(peekSystemEvents("agent:main:main")).toEqual([]);
expect(peekSystemEvents("agent:main:main")).toStrictEqual([]);
relay.dispose();
vi.useRealTimers();
});