feat: support .agents/skills/ directory for cross-agent skill discovery (#9966)

Adds loading from two .agents/skills/ locations:
- ~/.agents/skills/ (personal/user-level, source "agents-skills-personal")
- {workspace}/.agents/skills/ (project-level, source "agents-skills-project")

Precedence: extra < bundled < managed < personal .agents/skills < project .agents/skills < workspace.

Closes #8822
This commit is contained in:
Taras Lukavyi
2026-02-12 14:56:19 +01:00
committed by GitHub
parent dcb921944a
commit d85150357f
2 changed files with 172 additions and 2 deletions

View File

@@ -0,0 +1,153 @@
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { buildWorkspaceSkillsPrompt } from "./skills.js";
async function writeSkill(params: {
dir: string;
name: string;
description: string;
body?: string;
}) {
const { dir, name, description, body } = params;
await fs.mkdir(dir, { recursive: true });
await fs.writeFile(
path.join(dir, "SKILL.md"),
`---
name: ${name}
description: ${description}
---
${body ?? `# ${name}\n`}
`,
"utf-8",
);
}
describe("buildWorkspaceSkillsPrompt — .agents/skills/ directories", () => {
let fakeHome: string;
beforeEach(async () => {
fakeHome = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-home-"));
vi.spyOn(os, "homedir").mockReturnValue(fakeHome);
});
afterEach(() => {
vi.restoreAllMocks();
});
it("loads project .agents/skills/ above managed and below workspace", async () => {
const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-"));
const managedDir = path.join(workspaceDir, ".managed");
const bundledDir = path.join(workspaceDir, ".bundled");
await writeSkill({
dir: path.join(managedDir, "shared-skill"),
name: "shared-skill",
description: "Managed version",
});
await writeSkill({
dir: path.join(workspaceDir, ".agents", "skills", "shared-skill"),
name: "shared-skill",
description: "Project agents version",
});
// project .agents/skills/ wins over managed
const prompt1 = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: managedDir,
bundledSkillsDir: bundledDir,
});
expect(prompt1).toContain("Project agents version");
expect(prompt1).not.toContain("Managed version");
// workspace wins over project .agents/skills/
await writeSkill({
dir: path.join(workspaceDir, "skills", "shared-skill"),
name: "shared-skill",
description: "Workspace version",
});
const prompt2 = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: managedDir,
bundledSkillsDir: bundledDir,
});
expect(prompt2).toContain("Workspace version");
expect(prompt2).not.toContain("Project agents version");
});
it("loads personal ~/.agents/skills/ above managed and below project .agents/skills/", async () => {
const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-"));
const managedDir = path.join(workspaceDir, ".managed");
const bundledDir = path.join(workspaceDir, ".bundled");
await writeSkill({
dir: path.join(managedDir, "shared-skill"),
name: "shared-skill",
description: "Managed version",
});
await writeSkill({
dir: path.join(fakeHome, ".agents", "skills", "shared-skill"),
name: "shared-skill",
description: "Personal agents version",
});
// personal wins over managed
const prompt1 = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: managedDir,
bundledSkillsDir: bundledDir,
});
expect(prompt1).toContain("Personal agents version");
expect(prompt1).not.toContain("Managed version");
// project .agents/skills/ wins over personal
await writeSkill({
dir: path.join(workspaceDir, ".agents", "skills", "shared-skill"),
name: "shared-skill",
description: "Project agents version",
});
const prompt2 = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: managedDir,
bundledSkillsDir: bundledDir,
});
expect(prompt2).toContain("Project agents version");
expect(prompt2).not.toContain("Personal agents version");
});
it("loads unique skills from all .agents/skills/ sources alongside others", async () => {
const workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-"));
const managedDir = path.join(workspaceDir, ".managed");
const bundledDir = path.join(workspaceDir, ".bundled");
await writeSkill({
dir: path.join(managedDir, "managed-only"),
name: "managed-only",
description: "Managed only skill",
});
await writeSkill({
dir: path.join(fakeHome, ".agents", "skills", "personal-only"),
name: "personal-only",
description: "Personal only skill",
});
await writeSkill({
dir: path.join(workspaceDir, ".agents", "skills", "project-only"),
name: "project-only",
description: "Project only skill",
});
await writeSkill({
dir: path.join(workspaceDir, "skills", "workspace-only"),
name: "workspace-only",
description: "Workspace only skill",
});
const prompt = buildWorkspaceSkillsPrompt(workspaceDir, {
managedSkillsDir: managedDir,
bundledSkillsDir: bundledDir,
});
expect(prompt).toContain("managed-only");
expect(prompt).toContain("personal-only");
expect(prompt).toContain("project-only");
expect(prompt).toContain("workspace-only");
});
});

View File

@@ -4,6 +4,7 @@ import {
type Skill,
} from "@mariozechner/pi-coding-agent";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import type { OpenClawConfig } from "../../config/config.js";
import type {
@@ -121,7 +122,7 @@ function loadSkillEntries(
};
const managedSkillsDir = opts?.managedSkillsDir ?? path.join(CONFIG_DIR, "skills");
const workspaceSkillsDir = path.join(workspaceDir, "skills");
const workspaceSkillsDir = path.resolve(workspaceDir, "skills");
const bundledSkillsDir = opts?.bundledSkillsDir ?? resolveBundledSkillsDir();
const extraDirsRaw = opts?.config?.skills?.load?.extraDirs ?? [];
const extraDirs = extraDirsRaw
@@ -150,13 +151,23 @@ function loadSkillEntries(
dir: managedSkillsDir,
source: "openclaw-managed",
});
const personalAgentsSkillsDir = path.resolve(os.homedir(), ".agents", "skills");
const personalAgentsSkills = loadSkills({
dir: personalAgentsSkillsDir,
source: "agents-skills-personal",
});
const projectAgentsSkillsDir = path.resolve(workspaceDir, ".agents", "skills");
const projectAgentsSkills = loadSkills({
dir: projectAgentsSkillsDir,
source: "agents-skills-project",
});
const workspaceSkills = loadSkills({
dir: workspaceSkillsDir,
source: "openclaw-workspace",
});
const merged = new Map<string, Skill>();
// Precedence: extra < bundled < managed < workspace
// Precedence: extra < bundled < managed < agents-skills-personal < agents-skills-project < workspace
for (const skill of extraSkills) {
merged.set(skill.name, skill);
}
@@ -166,6 +177,12 @@ function loadSkillEntries(
for (const skill of managedSkills) {
merged.set(skill.name, skill);
}
for (const skill of personalAgentsSkills) {
merged.set(skill.name, skill);
}
for (const skill of projectAgentsSkills) {
merged.set(skill.name, skill);
}
for (const skill of workspaceSkills) {
merged.set(skill.name, skill);
}