fix(qa-lab): rename codex lifecycle fixtures to match knip ignore pattern (#85066)

knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts
(dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec786
as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip
flagged them as unexpected unused files and CI's check-dependencies job
has been failing on main since then. Rename to auth-profile.fixture.ts
and codex-plugin.fixture.ts and update the lifecycle test, the fixture
cross-import, and the six qa/scenarios markdown files that reference
them by path and qaImport specifier.
This commit is contained in:
Dallin Romney
2026-05-21 11:56:59 -07:00
committed by GitHub
parent b25a0d013b
commit ebd8b00cc3
9 changed files with 21 additions and 21 deletions

View File

@@ -7,7 +7,7 @@ import {
resolveCodexAuthProfile,
seedAuthProfiles,
snapshotAuthProfiles,
} from "./auth-profile-fixture.js";
} from "./auth-profile.fixture.js";
import {
CODEX_PLUGIN_CURRENT_VERSION,
CODEX_PLUGIN_LIFECYCLE_MESSAGES,
@@ -15,7 +15,7 @@ import {
evaluateCodexPluginLifecycle,
seedCodexPluginAt,
snapshotCodexPluginState,
} from "./codex-plugin-fixture.js";
} from "./codex-plugin.fixture.js";
import { createTempDirHarness } from "./temp-dir.test-helper.js";
const tempDirs = createTempDirHarness();

View File

@@ -1,6 +1,6 @@
import fs from "node:fs/promises";
import path from "node:path";
import { resolveCodexAuthProfile, type QaAuthProfileSnapshot } from "./auth-profile-fixture.js";
import { resolveCodexAuthProfile, type QaAuthProfileSnapshot } from "./auth-profile.fixture.js";
export const CODEX_PLUGIN_CURRENT_VERSION = "2026.5.20";
export const CODEX_PLUGIN_HEAD_VERSION = "head";

View File

@@ -18,7 +18,7 @@ successCriteria:
docsRefs:
- docs/cli/doctor.md
codeRefs:
- extensions/qa-lab/src/auth-profile-fixture.ts
- extensions/qa-lab/src/auth-profile.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -34,7 +34,7 @@ steps:
actions:
- set: auth
value:
expr: await qaImport("./auth-profile-fixture.js")
expr: await qaImport("./auth-profile.fixture.js")
- set: tmpRoot
value:
expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-auth-"))

View File

@@ -19,8 +19,8 @@ successCriteria:
docsRefs:
- docs/cli/doctor.md
codeRefs:
- extensions/qa-lab/src/auth-profile-fixture.ts
- extensions/qa-lab/src/codex-plugin-fixture.ts
- extensions/qa-lab/src/auth-profile.fixture.ts
- extensions/qa-lab/src/codex-plugin.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -39,10 +39,10 @@ steps:
actions:
- set: auth
value:
expr: await qaImport("./auth-profile-fixture.js")
expr: await qaImport("./auth-profile.fixture.js")
- set: plugin
value:
expr: await qaImport("./codex-plugin-fixture.js")
expr: await qaImport("./codex-plugin.fixture.js")
- forEach:
items:
ref: config.matrixCells

View File

@@ -20,8 +20,8 @@ docsRefs:
- docs/cli/plugins.md
- docs/plugins/install-overrides.md
codeRefs:
- extensions/qa-lab/src/codex-plugin-fixture.ts
- extensions/qa-lab/src/auth-profile-fixture.ts
- extensions/qa-lab/src/codex-plugin.fixture.ts
- extensions/qa-lab/src/auth-profile.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -36,10 +36,10 @@ steps:
actions:
- set: auth
value:
expr: await qaImport("./auth-profile-fixture.js")
expr: await qaImport("./auth-profile.fixture.js")
- set: plugin
value:
expr: await qaImport("./codex-plugin-fixture.js")
expr: await qaImport("./codex-plugin.fixture.js")
- set: tmpRoot
value:
expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-cold-"))

View File

@@ -18,7 +18,7 @@ successCriteria:
docsRefs:
- docs/cli/plugins.md
codeRefs:
- extensions/qa-lab/src/codex-plugin-fixture.ts
- extensions/qa-lab/src/codex-plugin.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -34,7 +34,7 @@ steps:
actions:
- set: plugin
value:
expr: await qaImport("./codex-plugin-fixture.js")
expr: await qaImport("./codex-plugin.fixture.js")
- set: gate
value:
expr: plugin.createCodexPluginInstallGate()

View File

@@ -17,7 +17,7 @@ docsRefs:
- docs/cli/plugins.md
- docs/cli/update.md
codeRefs:
- extensions/qa-lab/src/codex-plugin-fixture.ts
- extensions/qa-lab/src/codex-plugin.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -35,10 +35,10 @@ steps:
actions:
- set: auth
value:
expr: await qaImport("./auth-profile-fixture.js")
expr: await qaImport("./auth-profile.fixture.js")
- set: plugin
value:
expr: await qaImport("./codex-plugin-fixture.js")
expr: await qaImport("./codex-plugin.fixture.js")
- set: tmpRoot
value:
expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-new-"))

View File

@@ -17,7 +17,7 @@ docsRefs:
- docs/cli/plugins.md
- docs/cli/update.md
codeRefs:
- extensions/qa-lab/src/codex-plugin-fixture.ts
- extensions/qa-lab/src/codex-plugin.fixture.ts
- extensions/qa-lab/src/codex-plugin-lifecycle.test.ts
execution:
kind: flow
@@ -35,10 +35,10 @@ steps:
actions:
- set: auth
value:
expr: await qaImport("./auth-profile-fixture.js")
expr: await qaImport("./auth-profile.fixture.js")
- set: plugin
value:
expr: await qaImport("./codex-plugin-fixture.js")
expr: await qaImport("./codex-plugin.fixture.js")
- set: tmpRoot
value:
expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-old-"))